| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230404161101.GA3554747@bhelgaas>
Date: Tue, 4 Apr 2023 11:11:01 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Mickaël Salaün <mic@...ikod.net>,
Krzysztof Wilczyński <kw@...ux.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Michael Ellerman <mpe@...erman.id.au>,
Randy Dunlap <rdunlap@...radead.org>,
Arnd Bergmann <arnd@...db.de>,
Philippe Mathieu-Daudé <philmd@...aro.org>,
Niklas Schnelle <schnelle@...ux.ibm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Pali Rohár <pali@...nel.org>,
"Maciej W. Rozycki" <macro@...am.me.uk>,
Juergen Gross <jgross@...e.com>,
Dominik Brodowski <linux@...inikbrodowski.net>,
linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org,
sparclinux@...r.kernel.org, linux-pci@...r.kernel.org,
xen-devel@...ts.xenproject.org, linux-acpi@...r.kernel.org,
Miguel Ojeda <ojeda@...nel.org>,
Richard Henderson <richard.henderson@...aro.org>,
Ivan Kokshaysky <ink@...assic.park.msu.ru>,
Matt Turner <mattst88@...il.com>,
Russell King <linux@...linux.org.uk>,
Andrew Lunn <andrew@...n.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Gregory Clement <gregory.clement@...tlin.com>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Nicholas Piggin <npiggin@...il.com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Anatolij Gustschin <agust@...x.de>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
Rich Felker <dalias@...c.org>,
John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
"David S. Miller" <davem@...emloft.net>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Stefano Stabellini <sstabellini@...nel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
Subject: Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update
users
On Thu, Mar 30, 2023 at 07:24:27PM +0300, Andy Shevchenko wrote:
> Provide two new helper macros to iterate over PCI device resources and
> convert users.
>
> Looking at it, refactor existing pci_bus_for_each_resource() and convert
> users accordingly.
>
> Note, the amount of lines grew due to the documentation update.
>
> Changelog v8:
> - fixed issue with pci_bus_for_each_resource() macro (LKP)
> - due to above added a new patch to document how it works
> - moved the last patch to be #2 (Philippe)
> - added tags (Philippe)
>
> Changelog v7:
> - made both macros to share same name (Bjorn)
I didn't actually request the same name for both; I would have had no
idea how to even do that :)
v6 had:
pci_dev_for_each_resource_p(dev, res)
pci_dev_for_each_resource(dev, res, i)
and I suggested:
pci_dev_for_each_resource(dev, res)
pci_dev_for_each_resource_idx(dev, res, i)
because that pattern is used elsewhere. But you figured out how to do
it, and having one name is even better, so thanks for that extra work!
> - split out the pci_resource_n() conversion (Bjorn)
>
> Changelog v6:
> - dropped unused variable in PPC code (LKP)
>
> Changelog v5:
> - renamed loop variable to minimize the clash (Keith)
> - addressed smatch warning (Dan)
> - addressed 0-day bot findings (LKP)
>
> Changelog v4:
> - rebased on top of v6.3-rc1
> - added tag (Krzysztof)
>
> Changelog v3:
> - rebased on top of v2 by Mika, see above
> - added tag to pcmcia patch (Dominik)
>
> Changelog v2:
> - refactor to have two macros
> - refactor existing pci_bus_for_each_resource() in the same way and
> convert users
>
> Andy Shevchenko (6):
> kernel.h: Split out COUNT_ARGS() and CONCATENATE()
> PCI: Introduce pci_resource_n()
> PCI: Document pci_bus_for_each_resource() to avoid confusion
> PCI: Allow pci_bus_for_each_resource() to take less arguments
> EISA: Convert to use less arguments in pci_bus_for_each_resource()
> pcmcia: Convert to use less arguments in pci_bus_for_each_resource()
>
> Mika Westerberg (1):
> PCI: Introduce pci_dev_for_each_resource()
>
> .clang-format | 1 +
> arch/alpha/kernel/pci.c | 5 +-
> arch/arm/kernel/bios32.c | 16 +++--
> arch/arm/mach-dove/pcie.c | 10 ++--
> arch/arm/mach-mv78xx0/pcie.c | 10 ++--
> arch/arm/mach-orion5x/pci.c | 10 ++--
> arch/mips/pci/ops-bcm63xx.c | 8 +--
> arch/mips/pci/pci-legacy.c | 3 +-
> arch/powerpc/kernel/pci-common.c | 21 +++----
> arch/powerpc/platforms/4xx/pci.c | 8 +--
> arch/powerpc/platforms/52xx/mpc52xx_pci.c | 5 +-
> arch/powerpc/platforms/pseries/pci.c | 16 ++---
> arch/sh/drivers/pci/pcie-sh7786.c | 10 ++--
> arch/sparc/kernel/leon_pci.c | 5 +-
> arch/sparc/kernel/pci.c | 10 ++--
> arch/sparc/kernel/pcic.c | 5 +-
> drivers/eisa/pci_eisa.c | 4 +-
> drivers/pci/bus.c | 7 +--
> drivers/pci/hotplug/shpchp_sysfs.c | 8 +--
> drivers/pci/pci.c | 3 +-
> drivers/pci/probe.c | 2 +-
> drivers/pci/remove.c | 5 +-
> drivers/pci/setup-bus.c | 37 +++++-------
> drivers/pci/setup-res.c | 4 +-
> drivers/pci/vgaarb.c | 17 ++----
> drivers/pci/xen-pcifront.c | 4 +-
> drivers/pcmcia/rsrc_nonstatic.c | 9 +--
> drivers/pcmcia/yenta_socket.c | 3 +-
> drivers/pnp/quirks.c | 29 ++++-----
> include/linux/args.h | 13 ++++
> include/linux/kernel.h | 8 +--
> include/linux/pci.h | 72 +++++++++++++++++++----
> 32 files changed, 190 insertions(+), 178 deletions(-)
> create mode 100644 include/linux/args.h
Applied 2-7 to pci/resource for v6.4, thanks, I really like this!
I omitted
[1/7] kernel.h: Split out COUNT_ARGS() and CONCATENATE()"
only because it's not essential to this series and has only a trivial
one-line impact on include/linux/pci.h.
Bjorn
Powered by blists - more mailing lists