linux-kernel - [PATCH] selftests/mm: fix memory leak in child_memcmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  4 Apr 2023 11:12:34 +0800
From:   Feng Jiang <jiangfeng@...inos.cn>
To:     akpm@...ux-foundation.org, shuah@...nel.org
Cc:     linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, Feng Jiang <jiangfeng@...inos.cn>,
        Ming Xie <xieming@...inos.cn>
Subject: [PATCH] selftests/mm: fix memory leak in child_memcmp_fn

The allocated memory should be freed on return.

Signed-off-by: Feng Jiang <jiangfeng@...inos.cn>
Suggested-by: Ming Xie <xieming@...inos.cn>
---
 tools/testing/selftests/mm/cow.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c
index 0eb2e8180aa5..c0dd2dfca51b 100644
--- a/tools/testing/selftests/mm/cow.c
+++ b/tools/testing/selftests/mm/cow.c
@@ -162,6 +162,10 @@ static int child_memcmp_fn(char *mem, size_t size,
 {
 	char *old = malloc(size);
 	char buf;
+	int ret;
+
+	if (!old)
+		return -ENOMEM;
 
 	/* Backup the original content. */
 	memcpy(old, mem, size);
@@ -172,7 +176,10 @@ static int child_memcmp_fn(char *mem, size_t size,
 		;
 
 	/* See if we still read the old values. */
-	return memcmp(old, mem, size);
+	ret = memcmp(old, mem, size);
+	free(old);
+
+	return ret;
 }
 
 static int child_vmsplice_memcmp_fn(char *mem, size_t size,
-- 
2.39.2