linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2023 21:02:38 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Shreeya Patel <shreeya.patel@...labora.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, heiko@...ech.de
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com,
        Christopher Obbard <chris.obbard@...labora.com>
Subject: Re: [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B

On 04/04/2023 19:41, Shreeya Patel wrote:
> Add DT node to enable RTC support for Rock 5B board.
> 
> Signed-off-by: Shreeya Patel <shreeya.patel@...labora.com>
> Reviewed-by: Christopher Obbard <chris.obbard@...labora.com>
> ---
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 95805cb0adfa..fcb5af09e49b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>  	};
>  };
>  
> +&i2c6 {
> +	status = "okay";
> +
> +	hym8563: hym8563@51 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof