linux-kernel - Re: [PATCH] firmware: Use of_property_present() for testing DT property presence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2023 21:52:54 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Sudeep Holla <sudeep.holla@....com>,
        Cristian Marussi <cristian.marussi@....com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] firmware: Use of_property_present() for testing DT
 property presence

On Tue, Apr 04, 2023 at 11:58:46AM -0500, Rob Herring wrote:
> On Tue, Apr 04, 2023 at 03:30:02PM +0200, Thierry Reding wrote:
> > On Thu, Mar 23, 2023 at 12:00:30PM +0000, Sudeep Holla wrote:
> > > On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote:
> > > > It is preferred to use typed property access functions (i.e.
> > > > of_property_read_<type> functions) rather than low-level
> > > > of_get_property/of_find_property functions for reading properties. As
> > > > part of this, convert of_get_property/of_find_property calls to the
> > > > recently added of_property_present() helper when we just want to test
> > > > for presence of a property and nothing more.
> > > > 
> > > > Signed-off-by: Rob Herring <robh@...nel.org>
> > > > ---
> > > >  drivers/firmware/arm_scmi/optee.c | 2 +-
> > > 
> > > Acked-by: Sudeep Holla <sudeep.holla@....com>(for the SCMI part)
> > > 
> > > I am assuming you will route this as it has other changes as well in the
> > > patch.
> > 
> > I can also pick this up along with the Tegra changes if Rob doesn't
> > want to take it. But also feel free to take this through whatever tree
> > works best, for the Tegra parts:
> > 
> > Acked-by: Thierry Reding <treding@...dia.com>
> 
> You can take it. Thanks.

Applied now, thanks.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)