linux-kernel - Re: [PATCH] iio: dac: set varaiable max5522_channels storage-class-specifier to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee03cecef9139720a9818aa434dd34ae433d8e9d.camel@gmail.com>
Date:   Tue, 04 Apr 2023 08:43:32 +0200
From:   Nuno Sá <noname.nuno@...il.com>
To:     Tom Rix <trix@...hat.com>, jic23@...nel.org, lars@...afoo.de,
        angelo.dureghello@...esys.com
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: set varaiable max5522_channels
 storage-class-specifier to static

On Mon, 2023-04-03 at 21:38 -0400, Tom Rix wrote:
> smatch reports
> drivers/iio/dac/max5522.c:55:28: warning: symbol
>   'max5522_channels' was not declared. Should it be static?
> 
> This variable is only used in one file so it should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>