linux-kernel - Re: [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2023 11:19:53 +0200
From:   Michal Koutný <mkoutny@...e.com>
To:     Waiman Long <longman@...hat.com>
Cc:     Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Christian Brauner <brauner@...nel.org>,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        Juri Lelli <juri.lelli@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        gscrivan@...hat.com
Subject: Re: [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle
 CLONE_INTO_CGROUP properly

On Mon, Apr 03, 2023 at 01:18:42PM -0400, Waiman Long <longman@...hat.com> wrote:
> 1) PF_NO_SETAFFINITY flag - which won't be set in the case of fork() as it
> is for kthread only.
> 2) DL bandwidth - Juri has a cpuset outstanding to modify the way this check
> is being done. I want to wait until it is settled before tackling this, if
> necessary.

BTW what about CLONE_INTO_CGROUP where the target cpuset has empty
effective cpuset?

> 3) security_task_setscheduler() - the CLONE_INTO_CGROUP code has already
> checked that, we don't need to duplicate the check.

Not sure what this refers to.

> So we don't need a can_fork() check for now.

Anyway, good breakdown. Could you please add it to the commit message
too?

Regards,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)