linux-kernel - Re: [RESEND PATCH] memstick: fix memory leak if card device is never registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2023 14:03:27 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Maxim Levitsky <maximlevitsky@...il.com>,
        Alex Dubov <oakad@...oo.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Kay Sievers <kay.sievers@...y.org>, stable <stable@...nel.org>,
        Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
Subject: Re: [RESEND PATCH] memstick: fix memory leak if card device is never
 registered

On Tue, Apr 04, 2023 at 01:54:03PM +0200, Ulf Hansson wrote:
> On Sat, 1 Apr 2023 at 22:03, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > When calling dev_set_name() memory is allocated for the name for the
> > struct device.  Once that structure device is registered, or attempted
> > to be registerd, with the driver core, the driver core will handle
> > cleaning up that memory when the device is removed from the system.
> >
> > Unfortunatly for the memstick code, there is an error path that causes
> > the struct device to never be registered, and so the memory allocated in
> > dev_set_name will be leaked.  Fix that leak by manually freeing it right
> > before the memory for the device is freed.
> >
> > Cc: Maxim Levitsky <maximlevitsky@...il.com>
> > Cc: Alex Dubov <oakad@...oo.com>
> > Cc: Ulf Hansson <ulf.hansson@...aro.org>
> > Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> > Cc: Hans de Goede <hdegoede@...hat.com>
> > Cc: Kay Sievers <kay.sievers@...y.org>
> > Cc: linux-mmc@...r.kernel.org
> > Fixes: 0252c3b4f018 ("memstick: struct device - replace bus_id with dev_name(),
> > Cc: stable <stable@...nel.org>
> > Co-developed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Co-developed-by: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
> 
> Applied for fixes and by adding Mirsad's sob tag (according to the
> other thread [1]), thanks!

Wonderful, thanks for picking up that tag, and the patch.

greg k-h