linux-kernel - Re: [PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpF33qHhfxtUC1_A4DVAueUnMYG07QJr3cJouCCvxZF_PA@mail.gmail.com>
Date:   Wed, 5 Apr 2023 11:38:16 -0700
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     Tom Rix <trix@...hat.com>, mingo@...hat.com, peterz@...radead.org,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/psi: set varaiable psi_cgroups_enabled
 storage-class-specifier to static

On Wed, Apr 5, 2023 at 9:46 AM Johannes Weiner <hannes@...xchg.org> wrote:
>
> On Wed, Apr 05, 2023 at 12:36:02PM -0400, Tom Rix wrote:
> > smatch reports
> > kernel/sched/psi.c:143:1: warning: symbol
> >   'psi_cgroups_enabled' was not declared. Should it be static?
> >
> > This variable is only used in one file so should be static.
> >
> > Signed-off-by: Tom Rix <trix@...hat.com>
>
> Acked-by: Johannes Weiner <hannes@...xchg.org>

Acked-by: Suren Baghdasaryan <surenb@...gle.com>