[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <374d3d19-2459-064c-c7e6-7e13b4dc368d@linaro.org>
Date: Wed, 5 Apr 2023 22:38:24 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bhupesh Sharma <bhupesh.sharma@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-phy@...ts.infradead.org
Cc: agross@...nel.org, linux-kernel@...r.kernel.org,
andersson@...nel.org, bhupesh.linux@...il.com,
krzysztof.kozlowski@...aro.org, robh+dt@...nel.org,
konrad.dybcio@...aro.org, kishon@...nel.org, vkoul@...nel.org,
krzysztof.kozlowski+dt@...aro.org
Subject: Re: [PATCH v5 1/2] dt-bindings: phy: qcom,qmp-usb: Fix phy subnode
for SM6115 & QCM2290 USB3 PHY
On 05/04/2023 22:16, Bhupesh Sharma wrote:
> The USB3 SS (QMP) PHY found on Qualcomm SM6115 & QCM2290 SoCs is
> similar to sm8150 QMP PHY (which is named as 'usb_1_qmpphy' in
> sm8150 dtsi file, see [1]) in the sense that the phy subnode supports
usb_1_qmpphy on sm8150 is a USB+DP PHY, see
https://patchwork.kernel.org/project/linux-phy/patch/20230324215550.1966809-4-dmitry.baryshkov@linaro.org/
> 6 regs, namely TX lane 1, RX lane 1, PCS, TX lane 2, RX lane 2 and
> PCS_MISC.
>
> Update the dt-bindings document to reflect the same.
>
> [1]. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/sm8150.dtsi#n3394
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> ---
> .../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
> index e81a38281f8c..1575dc70bcf2 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
> @@ -276,7 +276,9 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,qcm2290-qmp-usb3-phy
> - qcom,sdm845-qmp-usb3-phy
> + - qcom,sm6115-qmp-usb3-phy
> - qcom,sm8150-qmp-usb3-phy
> - qcom,sm8350-qmp-usb3-phy
> - qcom,sm8450-qmp-usb3-phy
> @@ -318,12 +320,10 @@ allOf:
> enum:
> - qcom,ipq6018-qmp-usb3-phy
> - qcom,ipq8074-qmp-usb3-phy
> - - qcom,qcm2290-qmp-usb3-phy
> - qcom,sc7180-qmp-usb3-phy
> - qcom,sc8180x-qmp-usb3-phy
> - qcom,sdx55-qmp-usb3-uni-phy
> - qcom,sdx65-qmp-usb3-uni-phy
> - - qcom,sm6115-qmp-usb3-phy
> - qcom,sm8150-qmp-usb3-uni-phy
> - qcom,sm8250-qmp-usb3-phy
> then:
--
With best wishes
Dmitry
Powered by blists - more mailing lists