linux-kernel - Re: [PATCH v2 1/3] regulator: da9063: add voltage monitoring registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  5 Apr 2023 10:04:22 +0200
From:   Benjamin Bara <bbara93@...il.com>
To:     mazziesaccount@...il.com
Cc:     DLG-Adam.Thomson.Opensource@...renesas.com, bbara93@...il.com,
        benjamin.bara@...data.com, broonie@...nel.org,
        devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        lee@...nel.org, lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, stwiss.opensource@...semi.com,
        support.opensource@...semi.com
Subject: Re: [PATCH v2 1/3] regulator: da9063: add voltage monitoring registers

Thank you for the feedback!

On Wed, 5 Apr 2023 at 09:29, Matti Vaittinen <mazziesaccount@...il.com> wrote:
> Just a very minor thing - wouldn't this check be better as:
> if (regl->info->vmon.mask) ?
> We may have device(s) where 0 is a valid reg. However, mask 0 is
> probably not making sense - unless I misunderstand something?

This config is specific to the da9063. On this IC, register 0 is used for
PAGE_CON (control register). The registers relevant for voltage monitoring are
on 0x115-0x117. So IMHO this should be fine.