linux-kernel - [PATCH] rcu/kvfree: Delay the execution of drain_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230405021342.606264-1-qiang1.zhang@intel.com>
Date:   Wed,  5 Apr 2023 10:13:42 +0800
From:   Zqiang <qiang1.zhang@...el.com>
To:     urezki@...il.com, paulmck@...nel.org, frederic@...nel.org,
        joel@...lfernandes.org, qiang1.zhang@...el.com
Cc:     qiang.zhang1211@...il.com, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] rcu/kvfree: Delay the execution of drain_page_cache()

Currently, in kfree_rcu_shrink_scan(), the drain_page_cache() is
executed before kfree_rcu_monitor() to drain page cache, if the
bnode structure's->gp_snap has done, the kvfree_rcu_bulk() will
fill the page cache again in kfree_rcu_monitor(), this commit
therefore move drain_page_cache() after kfree_rcu_monitor() to
drain page cache.

Signed-off-by: Zqiang <qiang1.zhang@...el.com>
---
 kernel/rcu/tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 35be35f8236b..3461fc2640b9 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3424,8 +3424,8 @@ kfree_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
 		struct kfree_rcu_cpu *krcp = per_cpu_ptr(&krc, cpu);
 
 		count = krc_count(krcp);
-		count += drain_page_cache(krcp);
 		kfree_rcu_monitor(&krcp->monitor_work.work);
+		count += drain_page_cache(krcp);
 
 		sc->nr_to_scan -= count;
 		freed += count;
-- 
2.32.0