linux-kernel - Re: [PATCH 6/9] thermal/drivers/tegra: remove redundant msg in tegra_tsensor_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZC1mBUMF3MWmNqY5@orome>
Date:   Wed, 5 Apr 2023 14:13:57 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Yangtao Li <frank.li@...o.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-pm@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/9] thermal/drivers/tegra: remove redundant msg in
 tegra_tsensor_register_channel()

On Sat, Mar 18, 2023 at 10:44:09PM +0800, Yangtao Li wrote:
> The upper-layer devm_thermal_add_hwmon_sysfs() function can directly
> print error information.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
>  drivers/thermal/tegra/tegra30-tsensor.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c
> index cb584a5735ed..c243e9d76d3c 100644
> --- a/drivers/thermal/tegra/tegra30-tsensor.c
> +++ b/drivers/thermal/tegra/tegra30-tsensor.c
> @@ -523,8 +523,7 @@ static int tegra_tsensor_register_channel(struct tegra_tsensor *ts,
>  		return 0;
>  	}
>  
> -	if (devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd))
> -		dev_warn(ts->dev, "failed to add hwmon sysfs attributes\n");
> +	devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd);

I don't see any error messages output by devm_thermal_add_hwmon_sysfs()
nor any of the functions that it calls. Did I miss something?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)