linux-kernel - Re: [PATCH] arm64: dts: imx8mp-evk: add dual-role usb port1 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230405131637.GB11367@dragon>
Date:   Wed, 5 Apr 2023 21:16:37 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Andreas Henriksson <andreas@...al.se>
Cc:     Marco Felsch <m.felsch@...gutronix.de>, Jun Li <jun.li@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        dl-linux-imx <linux-imx@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Xu Yang <xu.yang_2@....com>
Subject: Re: [PATCH] arm64: dts: imx8mp-evk: add dual-role usb port1 support

On Mon, Apr 03, 2023 at 11:38:12AM +0200, Andreas Henriksson wrote:
> Hello Marco Felsch,
> 
> On Thu, Mar 30, 2023 at 04:38:13PM +0200, Marco Felsch wrote:
> > Hi,
> > 
> > On 23-03-27, Andreas Henriksson wrote:
> [...]
> > > / {
> > >     gpio-sbu-mux {
> > >         compatible = "gpio-sbu-mux";
> [...]
> > I didn't tested it but at the moment I don't see the problem with my
> > patch. 
> 
> As Jun Li helpfully explained my patch is not correct, so don't bother.
> 
> I don't have a problem with your patch, was just trying to share
> what I had done.
> 
> I've since learned that the board I'll be working on will not even have
> SS, so I will not pursue SBU. I'll most likely use your patches instead
> as they seem simpler than what I did and should fully meet my needs for
> an usb port that works in both host and device mode.
> 
> Not that it matters, but +1 from me on applying your patches.
> (If people are hesitant to do it because of lack of SS, then maybe
> that could be adressed by adding a comment setting the expectations?)

Marco,

Could you update the patch to mention a bit about Super-Speed support
as discussed here?

Shawn