linux-kernel - Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: mpm: Pass MSG RAM slice through phandle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e6e2590-ac78-400b-35ce-321d5e52f385@linaro.org>
Date:   Wed, 5 Apr 2023 15:49:24 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Andy Gross <agross@...nel.org>, linux-kernel@...r.kernel.org,
        Shawn Guo <shawn.guo@...aro.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Marc Zyngier <maz@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: mpm: Pass MSG
 RAM slice through phandle



On 5.04.2023 15:47, Rob Herring wrote:
> On Wed, Apr 05, 2023 at 07:22:40AM -0500, Rob Herring wrote:
>>
>> On Wed, 05 Apr 2023 12:48:34 +0200, Konrad Dybcio wrote:
>>> Due to the wild nature of the Qualcomm RPM Message RAM, we can't really
>>> use 'reg' to point to the MPM's slice of Message RAM without cutting into
>>> an already-defined RPM MSG RAM node used for GLINK and SMEM.
>>>
>>> Document passing the register space as a slice of SRAM through the
>>> qcom,rpm-msg-ram property. This also makes 'reg' deprecated.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>> ---
>>>  .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml   | 12 +++++++++---
>>>  1 file changed, 9 insertions(+), 3 deletions(-)
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.example.dts:22.35-38.11: Warning (node_name_vs_property_name): /example-0/interrupt-controller: node name and property name conflict
> 
> Looks like this is colliding with the example template which has to 
> craft an interrupt provider for 'interrupts' properties. Either adding a 
> parent node or using interrupts-extended instead should work-around it.
Check the devicetree-org issue linked in the cover letter, please!

I suppose wrapping it in a parent node could work as a temporary
measure, but since it belongs outside /soc, I'd have to make up
a bogus simple-bus, I think.

Konrad
> 
> Rob