[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <33d5daba-99fe-72db-0409-2099719a67ba@linaro.org>
Date: Wed, 5 Apr 2023 17:47:30 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: qcom: sm8450: label the Soundwire nodes
On 5.04.2023 08:09, Krzysztof Kozlowski wrote:
> Use labels, instead of comments, for Soundwire controllers. Naming them
> is useful, because they are specialized and have also naming in
> datasheet/programming guide.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index ce4b7d0a09ab..1dd000748f9e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -2153,13 +2153,13 @@ wsa2macro: codec@...0000 {
> #sound-dai-cells = <1>;
> };
>
> - /* WSA2 */
> swr4: soundwire-controller@...0000 {
> compatible = "qcom,soundwire-v1.7.0";
> reg = <0 0x031f0000 0 0x2000>;
> interrupts = <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&wsa2macro>;
> clock-names = "iface";
> + label = "WSA2";
>
> qcom,din-ports = <2>;
> qcom,dout-ports = <6>;
> @@ -2268,13 +2268,13 @@ wsamacro: codec@...0000 {
> #sound-dai-cells = <1>;
> };
>
> - /* WSA */
> swr0: soundwire-controller@...0000 {
> compatible = "qcom,soundwire-v1.7.0";
> reg = <0 0x03250000 0 0x2000>;
> interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&wsamacro>;
> clock-names = "iface";
> + label = "WSA";
>
> qcom,din-ports = <2>;
> qcom,dout-ports = <6>;
Powered by blists - more mailing lists