linux-kernel - Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05fa147c-116b-59b4-d14b-760bbefd7602@denx.de>
Date:   Wed, 5 Apr 2023 18:25:21 +0200
From:   Marek Vasut <marex@...x.de>
To:     Christoph Niedermaier <cniedermaier@...electronics.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
        Fabio Estevam <festevam@...x.de>,
        NXP Linux Team <linux-imx@....com>,
        kernel@...electronics.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

On 4/5/23 18:02, Christoph Niedermaier wrote:

[...]

> +/ {
> +	model = "DH electronics i.MX6ULL DHCOR on maveo box";
> +	compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
> +		     "fsl,imx6ull";
> +
> +	aliases {
> +		/delete-property/ mmc0; /* Avoid double definitions */
> +		/delete-property/ mmc1;
> +		mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Use root=PARTUUID= when booting to avoid any dependency on 
root=/dev/mmcblk2pN enumeration.

> +		spi0 = &ecspi4;
> +		spi3 = &ecspi1;
> +	};

[...]

> +&iomuxc {
> +	pinctrl-0 = <&pinctrl_hog_maveo_box>;
> +	pinctrl-names = "default";
> +
> +	pinctrl_hog_maveo_box: hog-maveo-box-grp {
> +		fsl,pins = <
> +			MX6UL_PAD_GPIO1_IO05__GPIO1_IO05	0x400120b0 /* BUTTON_USER */
> +			MX6UL_PAD_GPIO1_IO08__GPIO1_IO08	0x400120b0 /* BUTTON_RESET */
> +			MX6UL_PAD_CSI_PIXCLK__GPIO4_IO18	0x400120b0 /* LED_G */
> +			MX6UL_PAD_CSI_DATA02__GPIO4_IO23	0x400120b0 /* LED_B */

Should the "SION(1 << 30): Software Input On Field." bit really be set 
on GPIOs which are OUTPUT (like LEDs) ?

[...]