linux-kernel - Re: [PATCH] tracing/synthetic: Make lastcmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8c8a5f4-8e5f-c7d3-76dd-ce184a4dcc02@quicinc.com>
Date:   Thu, 6 Apr 2023 21:03:52 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>
CC:     Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        kernel test robot <lkp@...el.com>,
        Tze-nan Wu <Tze-nan.Wu@...iatek.com>
Subject: Re: [PATCH] tracing/synthetic: Make lastcmd_mutex static



On 4/6/2023 8:40 PM, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@...dmis.org>
> 
> The lastcmd_mutex is only used in trace_events_synth.c and should be
> static.
> 
> Link: https://lore.kernel.org/linux-trace-kernel/202304062033.cRStgOuP-lkp@intel.com/
> 
> Fixes: 4ccf11c4e8a8e ("tracing/synthetic: Fix races on freeing last_cmd")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

You have just beat me in pushing this.

Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-- Mukesh

> ---
>   kernel/trace/trace_events_synth.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
> index f0ff730125bf..d6a70aff2410 100644
> --- a/kernel/trace/trace_events_synth.c
> +++ b/kernel/trace/trace_events_synth.c
> @@ -44,7 +44,7 @@ enum { ERRORS };
>   
>   static const char *err_text[] = { ERRORS };
>   
> -DEFINE_MUTEX(lastcmd_mutex);
> +static DEFINE_MUTEX(lastcmd_mutex);
>   static char *last_cmd;
>   
>   static int errpos(const char *str)