linux-kernel - Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 19:38:19 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Saalim Quadri <danascape@...il.com>, lgirdwood@...il.com,
        broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, daniel.baluta@....com
Cc:     patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

On 05/04/2023 22:34, Saalim Quadri wrote:
> Convert the WM8523 audio CODEC bindings to DT schema
> 
> Signed-off-by: Saalim Quadri <danascape@...il.com>
> ---
>  .../devicetree/bindings/sound/wlf,wm8523.yaml | 40 +++++++++++++++++++
>  .../devicetree/bindings/sound/wm8523.txt      | 16 --------
>  2 files changed, 40 insertions(+), 16 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/wm8523.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
> new file mode 100644
> index 000000000000..decc395bb873
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/wlf,wm8523.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: WM8523 audio CODEC
> +
> +maintainers:
> +  - patches@...nsource.cirrus.com
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: wlf,wm8523
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#sound-dai-cells":
> +    const: 0
> +

Please squash all your three WM bindings (wm8711, wm8580 and wm8523)
into one binding, if they are the same. Probably other WM from your
previous submissions as well. We really do not need binding per each of
this simple codecs. If they ever need to grow, then we can split them.

Best regards,
Krzysztof