linux-kernel - Re: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6c8586f-a5d1-875f-b2c0-7871112cf1b1@linaro.org>
Date:   Thu, 6 Apr 2023 20:00:06 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Christoph Niedermaier <cniedermaier@...electronics.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
        Marek Vasut <marex@...x.de>, Fabio Estevam <festevam@...x.de>,
        NXP Linux Team <linux-imx@....com>,
        kernel <kernel@...electronics.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

On 06/04/2023 19:54, Christoph Niedermaier wrote:

>>> +++ b/arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts
>>> @@ -0,0 +1,361 @@
>>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
>>> +/*
>>> + * Copyright (C) 2023 DH electronics GmbH
>>> + * Copyright (C) 2023 Marantec electronics GmbH
>>> + *
>>> + * DHCOM iMX6ULL variant:
>>> + * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG
>>> + * DHCOR PCB number: 578-200 or newer
>>> + * maveo box PCB number: 525-200 or newer
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "imx6ull-dhcor-som.dtsi"
>>> +
>>> +/ {
>>> +     model = "DH electronics i.MX6ULL DHCOR on maveo box";
>>> +     compatible = "marantec,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
>>> +                  "fsl,imx6ull";
>>> +
>>> +     aliases {
>>> +             /delete-property/ mmc0; /* Avoid double definitions */
>>
>> I don't understand it. What is "double definition" of aliases?
> 
> Otherwise I end up like this:
> mmc0 = &usdhc1;
> mmc1 = &usdhc2;
> mmc2 = &usdhc2;
> 
> Is "Ensure unique allocation" a better comment here?
> 
>>
>>> +             /delete-property/ mmc1;
>>> +             mmc2 = &usdhc2; /* eMMC should be mmc2 */
>>
>> Why? How is this labeled on the board (physically or on schematics)? If
>> you answer here "for booting", then the answer is NAK. Don't add
>> software policies to Devicetree.
> 
> The name in the schematics is "SD2".

Answering also to above - then likely the aliases should be dropped from
SoM. I doubt that Som calls it SD1 and your board SD2...

Best regards,
Krzysztof