linux-kernel - Re: [PATCH v3 2/2] Revert "lib/firmware: fix a memory leak with multiple calls of trigger_batched_requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbbdc526-308b-32e6-75dd-05543e0a2129@alu.unizg.hr>
Date:   Thu, 6 Apr 2023 04:46:31 +0200
From:   Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Russ Weight <russell.h.weight@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] Revert "lib/firmware: fix a memory leak with
 multiple calls of trigger_batched_requests_store()"

On 06. 04. 2023. 03:43, Mirsad Goran Todorovac wrote:
> This reverts commit d59ff9027c628f0e9be344b28f3576566a274f2f.
> ---
>  lib/test_firmware.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/test_firmware.c b/lib/test_firmware.c
> index 51377b9ab6e3..454992bfdb2a 100644
> --- a/lib/test_firmware.c
> +++ b/lib/test_firmware.c
> @@ -1036,11 +1036,6 @@ ssize_t trigger_batched_requests_async_store(struct device *dev,
>  
>  	mutex_lock(&test_fw_mutex);
>  
> -	if (test_fw_config->reqs) {
> -		rc = -EBUSY;
> -		goto out;
> -	}
> -
>  	test_fw_config->reqs =
>  		vzalloc(array3_size(sizeof(struct test_batched_req),
>  				    test_fw_config->num_requests, 2));

NOTE: This was sent by an accident with the patch sending script.
Please ignore this erroneous patch.

Best regards,
Mirsad

-- 
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
 
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
The European Union

"I see something approaching fast ... Will it be friends with me?"