linux-kernel - Re: [PATCH 2/3] iio: pressure: Honeywell mpr pressure sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 21:43:57 +0200
From:   Andreas Klinger <ak@...klinger.de>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] iio: pressure: Honeywell mpr pressure sensor

Hi Jonathan,

thanks for the extensive review. Most of it is clear but one questions remain.
See below.

Jonathan Cameron <jic23@...nel.org> schrieb am Sa, 01. Apr 18:57:
> > +static void mpr_reset(struct mpr_data *data)
> > +{
> > +	if (data->gpiod_reset) {
> > +		gpiod_set_value(data->gpiod_reset, 0);
> > +		udelay(10);
> > +		gpiod_set_value(data->gpiod_reset, 1);
> > +	}
> 
> If there isn't a reset signal, I'd like to see an attempt at least to write
> all configuration registers to a known value (same as the one you'd
> get after reset).  

There is no configuration register in the sensor I could write to. But maybe I
didn't comprehend your point.

Andreas