linux-kernel - Re: [PATCH v1 0/3] PCI: brcmstb: Clkreq# accomodations of downstream device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 23:31:23 +0200
From:   Cyril Brulebois <kibi@...ian.org>
To:     Jim Quinlan <jim2101024@...il.com>
Cc:     linux-pci@...r.kernel.org,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Phil Elwell <phil@...pberrypi.com>,
        bcm-kernel-feedback-list@...adcom.com, james.quinlan@...adcom.com,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        Rob Herring <robh@...nel.org>, Hank Barta <hbarta@...il.com>
Subject: Re: [PATCH v1 0/3] PCI: brcmstb: Clkreq# accomodations of downstream
 device

Hi Jim,

Jim Quinlan <jim2101024@...il.com> (2023-04-06):
> The current driver assumes the downstream devices can provide clkreq# for
> ASPM.  These commits accomodate devices w/ or w/o clkreq# and also handle
> L1SS-capable devices.
> 
> The Raspian Linux folks have already been using a PCIe RC property
> "brcm,enable-l1ss".  These commits use the same property, in a
> backward-compatible manner, and the implementaion adds more detail and also
> automatically identifies devices w/o a clkreq# signal, i.e. most devices
> plugged into an RPi CM4 IO board.
> 
> Jim Quinlan (3):
>   dt-bindings: PCI: brcmstb: Add two optional props
>   PCI: brcmstb: Clkreq# accomodations of downstream device
>   PCI: brcmstb: Allow setting the completion timeout
> 
>  .../bindings/pci/brcm,stb-pcie.yaml           | 12 +++
>  drivers/pci/controller/pcie-brcmstb.c         | 93 +++++++++++++++++--
>  2 files changed, 95 insertions(+), 10 deletions(-)
> 
> 
> base-commit: 99ddf2254febae9eab7fb0bcc02c5322243f5c49

I've just verified with the exact same hardware as in Bugzilla#217276
that latest master (v6.3-rc5-137-gf2afccfefe7b) still gets a kernel
panic at boot, which goes away once those 3 patches are applied. Do you
need any extra information, log excerpt, or something like that?


Cheers,
-- 
Cyril Brulebois (kibi@...ian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)