linux-kernel - RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9224dcdbd62641cfb0ee691827d1b57d@dh-electronics.com>
Date:   Thu, 6 Apr 2023 21:52:41 +0000
From:   Christoph Niedermaier <cniedermaier@...electronics.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
        Marek Vasut <marex@...x.de>, Fabio Estevam <festevam@...x.de>,
        NXP Linux Team <linux-imx@....com>,
        kernel <kernel@...electronics.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

From: Krzysztof Kozlowski [mailto:krzk@...nel.org]
Sent: Thursday, April 6, 2023 10:38 PM
> On 06/04/2023 21:57, Christoph Niedermaier wrote:
>>>>>> +     aliases {
>>>>>> +             /delete-property/ mmc0; /* Avoid double definitions */
>>>>>
>>>>> I don't understand it. What is "double definition" of aliases?
>>>>
>>>> Otherwise I end up like this:
>>>> mmc0 = &usdhc1;
>>>> mmc1 = &usdhc2;
>>>> mmc2 = &usdhc2;
>>>>
>>>> Is "Ensure unique allocation" a better comment here?
>>>>
>>>>>
>>>>>> +             /delete-property/ mmc1;
>>>>>> +             mmc2 = &usdhc2; /* eMMC should be mmc2 */
>>>>>
>>>>> Why? How is this labeled on the board (physically or on schematics)? If
>>>>> you answer here "for booting", then the answer is NAK. Don't add
>>>>> software policies to Devicetree.
>>>>
>>>> The name in the schematics is "SD2".
>>>
>>> Answering also to above - then likely the aliases should be dropped from
>>> SoM. I doubt that Som calls it SD1 and your board SD2...
>>
>> Maybe I don't quite get it, but the hardware starts counting at 1. The first
>> interface is SD1 and it is used as WiFi. The second one is SD2 which is the
>> eMMC. So with this aliases it should match SD2 to mmc2.
>> Do you want me to delete the aliases in the include file "imx6ull-dhcor-som.dtsi"
> 
> Yes, because it incorrectly calls eMMC as mmc1. You said it is SD2, right?

Yes. I will do this in version 3.


Thanks and best regards
Christoph