linux-kernel - Re: [PATCH 02/32] perf/hisi-pcie: Assign parent for event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa68a994-7af7-53c0-a91a-bf00cff9d7ff@huawei.com>
Date:   Thu, 6 Apr 2023 11:56:07 +0800
From:   Yicong Yang <yangyicong@...wei.com>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Will Deacon <will@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <gregkh@...uxfoundation.org>
CC:     <yangyicong@...ilicon.com>, <linuxarm@...wei.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Shaokun Zhang <zhangshaokun@...ilicon.com>,
        Jiucheng Xu <jiucheng.xu@...ogic.com>,
        Khuong Dinh <khuong@...amperecomputing.com>,
        Robert Richter <rric@...nel.org>,
        Atish Patra <atishp@...shpatra.org>,
        Anup Patel <anup@...infault.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Frank Li <Frank.li@....com>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Vineet Gupta <vgupta@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Dave Jiang <dave.jiang@...el.com>, Wu Hao <hao.wu@...el.com>,
        Tom Rix <trix@...hat.com>, <linux-fpga@...r.kernel.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Liang Kan <kan.liang@...ux.intel.com>
Subject: Re: [PATCH 02/32] perf/hisi-pcie: Assign parent for event_source
 device

On 2023/4/4 21:41, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
> parent to be the PCI device.
> 
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Reviewed-by: Yicong Yang <yangyicong@...ilicon.com>

> ---
>  drivers/perf/hisilicon/hisi_pcie_pmu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c
> index 6fee0b6e163b..2cc88d75b895 100644
> --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c
> @@ -793,6 +793,7 @@ static int hisi_pcie_alloc_pmu(struct pci_dev *pdev, struct hisi_pcie_pmu *pcie_
>  	pcie_pmu->pmu = (struct pmu) {
>  		.name		= name,
>  		.module		= THIS_MODULE,
> +		.parent		= &pdev->dev,
>  		.event_init	= hisi_pcie_pmu_event_init,
>  		.pmu_enable	= hisi_pcie_pmu_enable,
>  		.pmu_disable	= hisi_pcie_pmu_disable,
>