linux-kernel - Re: [PATCH v6 2/2] leds: lp55xx: configure internal charge pump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 10:13:29 +0100
From:   Lee Jones <lee@...nel.org>
To:     Maarten Zanders <maarten.zanders@...d.be>
Cc:     Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] leds: lp55xx: configure internal charge pump

On Thu, 06 Apr 2023, Maarten Zanders wrote:

>
> > Sorry Maarten, just a couple of small nits.
>
> No need to be sorry.
>
>
> > This fits on one line, no?  < 100-chars?
>
> I thought the line length was meant to be <80 chars according to:
>
> https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings
>
> Happy to adapt if this shouldn't be taken as strict as I tried to do. Either
> way I'll post an update with a cleanup.

checkpatch.pl now checks for >100-chars.

> > > --- a/include/linux/platform_data/leds-lp55xx.h
> > > +++ b/include/linux/platform_data/leds-lp55xx.h
> > > @@ -73,6 +73,9 @@ struct lp55xx_platform_data {
> > >   	/* Clock configuration */
> > >   	u8 clock_mode;
> > >
> > > +	/* Charge pump mode */
> > > +	u32 charge_pump_mode;
> > That's a lot of data.  Does it need to be u32?
>
> No, it luckily doesn't get that big. This is to avoid an intermediate
> variable & casting as the DT parameter has to be 32bit (which I learned from
> an earlier comment). It was changed from u8 in v5 of the patch.

Fair enough.

--
Lee Jones [李琼斯]