linux-kernel - Re: [PATCH v2 10/10] memory: mtk-smi: mt8365: Add SMI Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ad8c606026586b682df5e0ce0c699e21a1e6fb7.camel@mediatek.com>
Date:   Thu, 6 Apr 2023 09:28:50 +0000
From:   Yong Wu (吴勇) <Yong.Wu@...iatek.com>
To:     "amergnat@...libre.com" <amergnat@...libre.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 10/10] memory: mtk-smi: mt8365: Add SMI Support

On Wed, 2023-04-05 at 10:06 +0200, Alexandre Mergnat wrote:
> 
> Add MT8365 SMI common support.
> 
> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
> ---
>  drivers/memory/mtk-smi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index 5a9754442bc7..477b5d1ffd46 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -713,6 +713,12 @@ static const struct mtk_smi_common_plat
> mtk_smi_sub_common_mt8195 = {
>         .has_gals = true,
>  };
> 
> +static const struct mtk_smi_common_plat mtk_smi_common_mt8365 = {
> +       .type     = MTK_SMI_GEN2,
> +       .has_gals = true,

mt8365 doesn't have "gals". Please remove this line, then the code is
ok for me.

Reviewed-by: Yong Wu <yong.wu@...iatek.com>

Thanks.

> +       .bus_sel  = F_MMU1_LARB(2) | F_MMU1_LARB(4),
> +};
> +
>  static const struct of_device_id mtk_smi_common_of_ids[] = {
>         {.compatible = "mediatek,mt2701-smi-common", .data =
> &mtk_smi_common_gen1},
>         {.compatible = "mediatek,mt2712-smi-common", .data =
> &mtk_smi_common_gen2},
> @@ -728,6 +734,7 @@ static const struct of_device_id
> mtk_smi_common_of_ids[] = {
>         {.compatible = "mediatek,mt8195-smi-common-vdo", .data =
> &mtk_smi_common_mt8195_vdo},
>         {.compatible = "mediatek,mt8195-smi-common-vpp", .data =
> &mtk_smi_common_mt8195_vpp},
>         {.compatible = "mediatek,mt8195-smi-sub-common", .data =
> &mtk_smi_sub_common_mt8195},
> +       {.compatible = "mediatek,mt8365-smi-common", .data =
> &mtk_smi_common_mt8365},
>         {}
>  };
> 
> 
> --
> 2.25.1
>