linux-kernel - Re: [PATCH] arm64: dts: ti: k3-j721s2-main: Enable support for SDR104 speed mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 15:15:46 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Bhavya Kapoor <b-kapoor@...com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <nm@...com>, <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>, <d-dhyani@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2-main: Enable support for SDR104
 speed mode



On 04/04/23 14:42, Bhavya Kapoor wrote:
> Remove sdhci-caps-mask to enable support for SDR104 speed mode for
> SD card in J721S2 SoC.
> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@...com>
> ---

Your commit message doesn't explain why?
Why was this disabled initalially and why is it okay to enable this now?

If disabling SDR104 was a bug, please add Fixes:

>  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 8915132efcc1..95c6151ed10c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -400,8 +400,6 @@ main_sdhci1: mmc@...0000 {
>  		ti,clkbuf-sel = <0x7>;
>  		ti,trm-icp = <0x8>;
>  		dma-coherent;
> -		/* Masking support for SDR104 capability */
> -		sdhci-caps-mask = <0x00000003 0x00000000>;
>  	};
>  
>  	main_navss: bus@...00000 {

-- 
Regards
Vignesh