linux-kernel - Re: [PATCHv1 1/3] dt-bindings: usb: Add RK3588 OHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230406105129.nuv3jcmwl7ugql3q@mercury.elektranox.org>
Date:   Thu, 6 Apr 2023 12:51:29 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Alan Stern <stern@...land.harvard.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCHv1 1/3] dt-bindings: usb: Add RK3588 OHCI

Hi Krzysztof,

On Thu, Apr 06, 2023 at 09:45:11AM +0200, Krzysztof Kozlowski wrote:
> On 04/04/2023 16:53, Sebastian Reichel wrote:
> > Add compatible for RK3588 OHCI. As far as I know it's fully
> > compatible with generic-ohci.
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> > ---
> >  .../devicetree/bindings/usb/generic-ohci.yaml  | 18 ++++++++++++++++--
> >  1 file changed, 16 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > index a9ba7257b884..d84732a100ba 100644
> > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > @@ -44,6 +44,7 @@ properties:
> >                - hpe,gxp-ohci
> >                - ibm,476gtr-ohci
> >                - ingenic,jz4740-ohci
> > +              - rockchip,rk3588-ohci
> >                - snps,hsdk-v1.0-ohci
> >            - const: generic-ohci
> >        - enum:
> > @@ -68,8 +69,6 @@ properties:
> >      maxItems: 2
> >  
> >    clocks:
> > -    minItems: 1
> > -    maxItems: 3
> 
> The constraints here should stay.

dtbs_check complained about the 4 RK3588 clock entries if this
stays. That's why I moved them to the condition down below into
the else branch.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)