| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202304061914.N1Hmx12N-lkp@intel.com>
Date: Thu, 6 Apr 2023 19:40:21 +0800
From: kernel test robot <lkp@...el.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
Peter Xu <peterx@...hat.com>,
David Hildenbrand <david@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Michał Mirosław <emmir@...gle.com>,
Andrei Vagin <avagin@...il.com>,
Danylo Mocherniuk <mdanylo@...gle.com>,
Paul Gofman <pgofman@...eweavers.com>,
Cyrill Gorcunov <gorcunov@...il.com>,
Mike Rapoport <rppt@...nel.org>, Nadav Amit <namit@...are.com>
Cc: oe-kbuild-all@...ts.linux.dev,
Linux Memory Management List <linux-mm@...ck.org>,
Alexander Viro <viro@...iv.linux.org.uk>,
Shuah Khan <skhan@...uxfoundation.org>,
Christian Brauner <brauner@...nel.org>,
Yang Shi <shy828301@...il.com>,
Vlastimil Babka <vbabka@...e.cz>,
"Liam R . Howlett" <Liam.Howlett@...cle.com>,
Yun Zhou <yun.zhou@...driver.com>,
Suren Baghdasaryan <surenb@...gle.com>,
Alex Sierra <alex.sierra@....com>,
Muhammad Usama Anjum <usama.anjum@...labora.com>,
Matthew Wilcox <willy@...radead.org>,
Pasha Tatashin <pasha.tatashin@...een.com>,
Axel Rasmussen <axelrasmussen@...gle.com>,
"Gustavo A . R . Silva" <gustavoars@...nel.org>,
Dan Williams <dan.j.williams@...el.com>,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-kselftest@...r.kernel.org, Greg KH <greg@...ah.com>
Subject: Re: [PATCH v12 2/5] fs/proc/task_mmu: Implement IOCTL to get and
optionally clear info about PTEs
Hi Muhammad,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on next-20230406]
[cannot apply to linus/master v6.3-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Muhammad-Usama-Anjum/userfaultfd-UFFD_FEATURE_WP_ASYNC/20230406-154314
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20230406074005.1784728-3-usama.anjum%40collabora.com
patch subject: [PATCH v12 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs
config: arc-randconfig-r023-20230405 (https://download.01.org/0day-ci/archive/20230406/202304061914.N1Hmx12N-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/f13abb36f64c77913509da8ca157512d2fb9f031
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Muhammad-Usama-Anjum/userfaultfd-UFFD_FEATURE_WP_ASYNC/20230406-154314
git checkout f13abb36f64c77913509da8ca157512d2fb9f031
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash fs/proc/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304061914.N1Hmx12N-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
fs/proc/task_mmu.c: In function 'pagemap_scan_pmd_entry':
>> fs/proc/task_mmu.c:1921:37: error: 'HPAGE_SIZE' undeclared (first use in this function); did you mean 'PAGE_SIZE'?
1921 | ((end - start < HPAGE_SIZE) ||
| ^~~~~~~~~~
| PAGE_SIZE
fs/proc/task_mmu.c:1921:37: note: each undeclared identifier is reported only once for each function it appears in
>> fs/proc/task_mmu.c:1939:35: error: passing argument 1 of 'uffd_wp_range' from incompatible pointer type [-Werror=incompatible-pointer-types]
1939 | uffd_wp_range(vma, start, HPAGE_SIZE, true) < 0)
| ^~~
| |
| struct vm_area_struct *
In file included from include/linux/mm_inline.h:9,
from fs/proc/task_mmu.c:3:
include/linux/userfaultfd_k.h:215:52: note: expected 'struct mm_struct *' but argument is of type 'struct vm_area_struct *'
215 | static inline long uffd_wp_range(struct mm_struct *dst_mm,
| ~~~~~~~~~~~~~~~~~~^~~~~~
>> fs/proc/task_mmu.c:1939:40: warning: passing argument 2 of 'uffd_wp_range' makes pointer from integer without a cast [-Wint-conversion]
1939 | uffd_wp_range(vma, start, HPAGE_SIZE, true) < 0)
| ^~~~~
| |
| long unsigned int
include/linux/userfaultfd_k.h:216:57: note: expected 'struct vm_area_struct *' but argument is of type 'long unsigned int'
216 | struct vm_area_struct *vma,
| ~~~~~~~~~~~~~~~~~~~~~~~^~~
>> fs/proc/task_mmu.c:1939:21: error: too few arguments to function 'uffd_wp_range'
1939 | uffd_wp_range(vma, start, HPAGE_SIZE, true) < 0)
| ^~~~~~~~~~~~~
include/linux/userfaultfd_k.h:215:20: note: declared here
215 | static inline long uffd_wp_range(struct mm_struct *dst_mm,
| ^~~~~~~~~~~~~
fs/proc/task_mmu.c:1965:35: error: passing argument 1 of 'uffd_wp_range' from incompatible pointer type [-Werror=incompatible-pointer-types]
1965 | uffd_wp_range(vma, addr, PAGE_SIZE, true) < 0)
| ^~~
| |
| struct vm_area_struct *
include/linux/userfaultfd_k.h:215:52: note: expected 'struct mm_struct *' but argument is of type 'struct vm_area_struct *'
215 | static inline long uffd_wp_range(struct mm_struct *dst_mm,
| ~~~~~~~~~~~~~~~~~~^~~~~~
fs/proc/task_mmu.c:1965:40: warning: passing argument 2 of 'uffd_wp_range' makes pointer from integer without a cast [-Wint-conversion]
1965 | uffd_wp_range(vma, addr, PAGE_SIZE, true) < 0)
| ^~~~
| |
| long unsigned int
include/linux/userfaultfd_k.h:216:57: note: expected 'struct vm_area_struct *' but argument is of type 'long unsigned int'
216 | struct vm_area_struct *vma,
| ~~~~~~~~~~~~~~~~~~~~~~~^~~
fs/proc/task_mmu.c:1965:21: error: too few arguments to function 'uffd_wp_range'
1965 | uffd_wp_range(vma, addr, PAGE_SIZE, true) < 0)
| ^~~~~~~~~~~~~
include/linux/userfaultfd_k.h:215:20: note: declared here
215 | static inline long uffd_wp_range(struct mm_struct *dst_mm,
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +1921 fs/proc/task_mmu.c
1891
1892 static int pagemap_scan_pmd_entry(pmd_t *pmd, unsigned long start,
1893 unsigned long end, struct mm_walk *walk)
1894 {
1895 struct pagemap_scan_private *p = walk->private;
1896 bool is_written, is_file, is_present, is_swap;
1897 struct vm_area_struct *vma = walk->vma;
1898 unsigned long addr = end;
1899 spinlock_t *ptl;
1900 int ret = 0;
1901 pte_t *pte;
1902
1903 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
1904 ptl = pmd_trans_huge_lock(pmd, vma);
1905 if (ptl) {
1906 unsigned long n_pages = (end - start)/PAGE_SIZE;
1907
1908 is_written = !is_pmd_uffd_wp(*pmd);
1909 is_file = vma->vm_file;
1910 is_present = pmd_present(*pmd);
1911 is_swap = is_swap_pmd(*pmd);
1912
1913 spin_unlock(ptl);
1914
1915 /*
1916 * Break huge page into small pages if the WP operation need to
1917 * be performed is on a portion of the huge page or if max_pages
1918 * pages limit would exceed.
1919 */
1920 if (is_written && PM_SCAN_OP_IS_WP(p) &&
> 1921 ((end - start < HPAGE_SIZE) ||
1922 (p->max_pages &&
1923 (p->max_pages - p->found_pages) < n_pages))) {
1924
1925 split_huge_pmd(vma, pmd, start);
1926 goto process_smaller_pages;
1927 }
1928
1929 if (p->max_pages &&
1930 p->found_pages + n_pages > p->max_pages)
1931 n_pages = p->max_pages - p->found_pages;
1932
1933 ret = pagemap_scan_output(is_written, is_file, is_present,
1934 is_swap, p, start, n_pages);
1935 if (ret < 0)
1936 return ret;
1937
1938 if (is_written && PM_SCAN_OP_IS_WP(p) &&
> 1939 uffd_wp_range(vma, start, HPAGE_SIZE, true) < 0)
1940 ret = -EINVAL;
1941
1942 return ret;
1943 }
1944 process_smaller_pages:
1945 if (pmd_trans_unstable(pmd))
1946 return 0;
1947 #endif
1948
1949 for (addr = start; addr < end && !ret; pte++, addr += PAGE_SIZE) {
1950 pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl);
1951
1952 is_written = !is_pte_uffd_wp(*pte);
1953 is_file = vma->vm_file;
1954 is_present = pte_present(*pte);
1955 is_swap = is_swap_pte(*pte);
1956
1957 pte_unmap_unlock(pte, ptl);
1958
1959 ret = pagemap_scan_output(is_written, is_file, is_present,
1960 is_swap, p, addr, 1);
1961 if (ret < 0)
1962 return ret;
1963
1964 if (is_written && PM_SCAN_OP_IS_WP(p) &&
1965 uffd_wp_range(vma, addr, PAGE_SIZE, true) < 0)
1966 return -EINVAL;
1967 }
1968
1969 cond_resched();
1970 return ret;
1971 }
1972
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists