linux-kernel - Re: [PATCH 1/2] drm/vkms: Drop vkms_connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878rf58c6z.fsf@minerva.mail-host-address-is-not-set>
Date:   Thu, 06 Apr 2023 13:47:16 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Maíra Canal <mcanal@...lia.com>,
        linux-kernel@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Marius Vlad <marius.vlad@...labora.com>,
        David Airlie <airlied@...il.com>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        Melissa Wen <melissa.srw@...il.com>,
        Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 1/2] drm/vkms: Drop vkms_connector_destroy() wrapper

Maíra Canal <mcanal@...lia.com> writes:

Hello Maíra,

> On 4/6/23 08:11, Daniel Vetter wrote:
>> On Thu, Apr 06, 2023 at 01:02:34PM +0200, Javier Martinez Canillas wrote:
>>> This helper is just a wrapper that calls drm_connector_cleanup(), there's
>>> no need to have another level of indirection.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
>> 
>> On both patches:
>> 
>> Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
>> 
>> Aside, would be a nice cleanup to move vkms output stuff (crtc and
>> connector) over to the drmm_ stuff. The plane already does that.
>
> I sent a patch [1] a while ago moving the CRTC to the drmm_ functions.
> If you could take a look at it, it would be great.
>
> [1] https://lore.kernel.org/dri-devel/20230116205800.1266227-1-mcanal@igalia.com/T/
>

I've now reviewed both patches from your series and they look good to me.

> Best Regards,
> - Maíra Canal
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat