linux-kernel - Re: [PATCH] staging: greybus: drop loopback test files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 07:12:17 -0500
From:   Alex Elder <elder@...e.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev
Cc:     linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>,
        Alex Elder <elder@...nel.org>,
        Jack Schofield <schofija@...gonstate.edu>,
        Vaibhav Nagare <vnagare@...hat.com>,
        greybus-dev@...ts.linaro.org
Subject: Re: [PATCH] staging: greybus: drop loopback test files

On 4/6/23 3:18 AM, Greg Kroah-Hartman wrote:
> The greybus loopback test tool does not belong burried down in a
> driver-specific directory.  If it is needed, it should be somewhere
> else, like in the testing directory.  But as the loopback driver is
> probably never going to be merged out of the staging directory, let's
> just delete the test alltogether for now.  If it's needed in the future,
> it can be brought back with a revert.
> 
> Also, having an Android.mk file in the kernel source tree breaks some
> Android build systems when trying to build from a read-only source tree,
> the report of which prompted this being a good reason to remove it as
> well.
> 
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Alex Elder <elder@...nel.org>
> Cc: Jack Schofield <schofija@...gonstate.edu>
> Cc: Vaibhav Nagare <vnagare@...hat.com>
> Cc: greybus-dev@...ts.linaro.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

That's a surprising amount of code.  And perhaps there
are better ways of exposing this type of information.
Anyway, no objection here.

Acked-by: Alex Elder <elder@...aro.org>

> ---
>   drivers/staging/greybus/tools/.gitignore      |   2 -
>   drivers/staging/greybus/tools/Android.mk      |  10 -
>   drivers/staging/greybus/tools/Makefile        |  33 -
>   drivers/staging/greybus/tools/README.loopback | 198 ----
>   drivers/staging/greybus/tools/lbtest          | 169 ---
>   drivers/staging/greybus/tools/loopback_test.c | 979 ------------------
>   6 files changed, 1391 deletions(-)
>   delete mode 100644 drivers/staging/greybus/tools/.gitignore
>   delete mode 100644 drivers/staging/greybus/tools/Android.mk
>   delete mode 100644 drivers/staging/greybus/tools/Makefile
>   delete mode 100644 drivers/staging/greybus/tools/README.loopback
>   delete mode 100755 drivers/staging/greybus/tools/lbtest
>   delete mode 100644 drivers/staging/greybus/tools/loopback_test.c
>