linux-kernel - Re: LTP: list of failures on 32bit and compat mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230406124812.GA1589248@pevik>
Date:   Thu, 6 Apr 2023 14:48:12 +0200
From:   Petr Vorel <pvorel@...e.cz>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        open list <linux-kernel@...r.kernel.org>,
        LTP List <ltp@...ts.linux.it>, llvm@...ts.linux.dev,
        chrubis <chrubis@...e.cz>, Nathan Chancellor <nathan@...nel.org>,
        Anders Roxell <anders.roxell@...aro.org>,
        Daniel Díaz <daniel.diaz@...aro.org>,
        Benjamin Copeland <ben.copeland@...aro.org>,
        Tudor Cretu <tudor.cretu@....com>
Subject: Re: LTP: list of failures on 32bit and compat mode

Hi all,

> On Thu, Apr 6, 2023, at 12:56, Petr Vorel wrote:
> >> On Thu, Apr 6, 2023, at 11:11, Naresh Kamboju wrote:

> >> > mq_timedreceive01
> >> > mq_timedreceive01.c:197: TPASS: mq_timedreceive() failed expectedly: EINTR (4)
> >> > tst_test.c:1581: TBROK: Test killed by SIGSEGV!

> >> I think this is the same problem as fstatfs02, where ltp passes
> >> an invalid pointer and expects EFAULT, but musl touches the data
> >> first in order to do the time64 conversion. Needs the same fix.

> > FYI mq_timedreceive01 is broken on 32bit systems with glibc
> > (in current LTP master):


> > EINTR (4)
> > tst_test.c:1618: TBROK: Test killed by SIGSEGV!

> Right, I see this has the same time64 logic as musl now.

> >> > recvmmsg01.c:92: TPASS: recvmmsg() overflow in nanoseconds in timeout
> >> > : EINVAL (22)
> >> > tst_test.c:1581: TBROK: Test killed by SIGSEGV!

> >> Same time64 conversion issue as above.

> > Besides the same problem with shm permissions on musl I see SIGSEGV also on
> > 64bit musl on current LTP master.

> Ah, I see. This must be the padding code then, not the time64
> conversion:

> +int recvmmsg(int fd, struct mmsghdr *msgvec, unsigned int vlen, unsigned int flags, struct timespec *timeout)
> +{
> +#if LONG_MAX > INT_MAX
> +       struct mmsghdr *mh = msgvec;
> +       unsigned int i;
> +       for (i = vlen; i; i--, mh++)
> +               mh->msg_hdr.__pad1 = mh->msg_hdr.__pad2 = 0;
> +#endif

I suppose this is a suggestion for fix in LTP. I'd expect is should go into
testcases/kernel/syscalls/sendmmsg/sendmmsg_var.h into static inline int
sys_recvmmsg(...)

But that at least on glibc 64bit compilation does not see __pad1 member:

../sendmmsg/sendmmsg_var.h: In function ‘sys_recvmmsg’:
../sendmmsg/sendmmsg_var.h:47:28: error: ‘struct msghdr’ has no member named ‘__pad1’
   47 |                 mh->msg_hdr.__pad1 = mh->msg_hdr.__pad2 = 0;
      |                            ^

Kind regards,
Petr

>        Arnd