linux-kernel - Re: [PATCH] phy: smsc: Implement .aneg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa6415be-e99b-46df-bb3b-d2c732a33f31@lunn.ch>
Date:   Thu, 6 Apr 2023 16:19:31 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     Lukasz Majewski <lukma@...x.de>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: smsc: Implement .aneg_done callback for LAN8720Ai

On Thu, Apr 06, 2023 at 03:48:43PM +0200, Simon Horman wrote:
> On Thu, Apr 06, 2023 at 03:11:27PM +0200, Lukasz Majewski wrote:
> > The LAN8720Ai has special bit (12) in the PHY SPECIAL
> > CONTROL/STATUS REGISTER (dec 31) to indicate if the
> > AutoNeg is finished.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@...x.de>
> 
> Hi Lukasz,
> 
> I think you need to rebase this on net-next.
> 
> If you repost please also include 'net-next' in the subject:
> [PATCH net-next v2].
> 
> And a note about the changes between v1 and v2.

This actually seems like a fix. So it should probably be based on net,
and have a Fixes: tag.

Lukasz, how does this bit differ to the one in BMSR? Is the BMSR bit
broken? Is there an errata for this? It would be good to describe the
problem you see which this patch fixes.

	Andrew