linux-kernel - Re: [PATCH v5 3/4] dt-bindings: arm: qcom: Add Acer Aspire 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8de5632-09f9-565a-ec06-814cc23c12ea@linaro.org>
Date:   Fri, 7 Apr 2023 21:33:34 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Doug Anderson <dianders@...omium.org>,
        Nikita Travkin <nikita@...n.ru>
Cc:     agross@...nel.org, andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, konrad.dybcio@...aro.org,
        quic_srivasam@...cinc.com, judyhsiao@...omium.org,
        mka@...omium.org, cros-qcom-dts-watchers@...omium.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v5 3/4] dt-bindings: arm: qcom: Add Acer Aspire 1

On 07/04/2023 18:23, Doug Anderson wrote:
> Hi,
> 
> On Fri, Apr 7, 2023 at 8:14 AM Nikita Travkin <nikita@...n.ru> wrote:
>>
>> Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.
>>
>> Signed-off-by: Nikita Travkin <nikita@...n.ru>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>> Changes in v2:
>>  - Merge with IDP (Krzysztof)
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index f8d29b65f28b..db97a61e8ccb 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -367,9 +367,9 @@ properties:
>>                - qcom,qru1000-idp
>>            - const: qcom,qru1000
>>
>> -      - description: Qualcomm Technologies, Inc. SC7180 IDP
>> -        items:
>> +      - items:
>>            - enum:
>> +              - acer,aspire1
>>                - qcom,sc7180-idp
>>            - const: qcom,sc7180
> 
> If Krzysztof is happy then I have no real objections here. That being
> said, I personally would have updated the description to be more
> generic and not say "IDP" anymore. Something like "Non-Chromebook
> sc7180 boards".

I am fine with both - dropping the description or changing it to
something meaningful.

Best regards,
Krzysztof