linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm630: move DSI opp-table out of DSI node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc51155e-9538-3a81-98ca-da8722462b71@linaro.org>
Date:   Fri, 7 Apr 2023 21:33:43 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm630: move DSI opp-table out of DSI
 node



On 7.04.2023 21:26, Krzysztof Kozlowski wrote:
> The DSI OPP table on SDM630 is used by one DSI0, but on SDM660 is shared
> by two nodes (DSI0 and DSI1), thus it should be rather in top-level, not
> in DSI0.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> A cleanup patch to commit a2e5260d0755 ("arm64: dts: qcom: sdm630: move
> DSI opp-table into DSI node").
> 
> Follow-up to:
> https://lore.kernel.org/all/20230407163442.ckbd4vxa5b2xu3eu@ripper/
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sdm630.dtsi | 38 ++++++++++++++--------------
>  1 file changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 8bdb36a63474..b91e423a3cfc 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -328,6 +328,25 @@ memory@...00000 {
>  		reg = <0x0 0x80000000 0x0 0x0>;
>  	};
>  
> +	dsi_opp_table: opp-table-dsi {
> +		compatible = "operating-points-v2";
> +
> +		opp-131250000 {
> +			opp-hz = /bits/ 64 <131250000>;
> +			required-opps = <&rpmpd_opp_svs>;
> +		};
> +
> +		opp-210000000 {
> +			opp-hz = /bits/ 64 <210000000>;
> +			required-opps = <&rpmpd_opp_svs_plus>;
> +		};
> +
> +		opp-262500000 {
> +			opp-hz = /bits/ 64 <262500000>;
> +			required-opps = <&rpmpd_opp_nom>;
> +		};
> +	};
> +
>  	pmu {
>  		compatible = "arm,armv8-pmuv3";
>  		interrupts = <GIC_PPI 6 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1591,25 +1610,6 @@ dsi0: dsi@...4000 {
>  
>  				status = "disabled";
>  
> -				dsi_opp_table: opp-table {
> -					compatible = "operating-points-v2";
> -
> -					opp-131250000 {
> -						opp-hz = /bits/ 64 <131250000>;
> -						required-opps = <&rpmpd_opp_svs>;
> -					};
> -
> -					opp-210000000 {
> -						opp-hz = /bits/ 64 <210000000>;
> -						required-opps = <&rpmpd_opp_svs_plus>;
> -					};
> -
> -					opp-262500000 {
> -						opp-hz = /bits/ 64 <262500000>;
> -						required-opps = <&rpmpd_opp_nom>;
> -					};
> -				};
> -
>  				ports {
>  					#address-cells = <1>;
>  					#size-cells = <0>;