linux-kernel - Re: [PATCH v2] PCI/EDR: Clear PCIe Device Status errors after EDR error recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b8c23fd-f1b0-1687-052a-9c6b7d70f34d@linux.intel.com>
Date:   Fri, 7 Apr 2023 15:25:17 -0700
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        "Natu, Mahesh" <mahesh.natu@...el.com>
Subject: Re: [PATCH v2] PCI/EDR: Clear PCIe Device Status errors after EDR
 error recovery



On 4/7/23 2:52 PM, Bjorn Helgaas wrote:
> On Fri, Apr 07, 2023 at 04:51:44PM -0500, Bjorn Helgaas wrote:
>> I'll post a follow-up patch to add a couple comments there,
>> too.
> 
> Comments I propose:
> 
> 
>     PCI/EDR: Add edr_handle_event() comments
>     
>     EDR documentation is a bit sketchy.  Add a couple comments to
>     edr_handle_event() about the devices involved.
>     
>     Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> diff --git a/drivers/pci/pcie/edr.c b/drivers/pci/pcie/edr.c
> index 87734e4c3c20..135ddb53661c 100644
> --- a/drivers/pci/pcie/edr.c
> +++ b/drivers/pci/pcie/edr.c
> @@ -151,9 +151,17 @@ static void edr_handle_event(acpi_handle handle, u32 event, void *data)
>  	if (event != ACPI_NOTIFY_DISCONNECT_RECOVER)
>  		return;
>  
> +	/*
> +	 * pdev itself is still present, but one or more of its child
> +	 * devices have been disconnected (ACPI v6.3, sec 5.6.6).
> +	 */

Maybe add info that pdev can be a root port or a downstream port?

>  	pci_info(pdev, "EDR event received\n");
>  
> -	/* Locate the port which issued EDR event */
> +	/*
> +	 * Locate the port that experienced the containment event.  pdev
> +	 * may be that port or a parent of it (PCI Firmware r3.3, sec
> +	 * 4.6.13).
> +	 */
>  	edev = acpi_dpc_port_get(pdev);
>  	if (!edev) {
>  		pci_err(pdev, "Firmware failed to locate DPC port\n");


Otherwise, looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer