linux-kernel - Re: [PATCH] power: supply: hwmon: constify pointers to hwmon_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b88f2a0b-41fc-0cf7-5088-64edcd9dd927@roeck-us.net>
Date:   Fri, 7 Apr 2023 16:06:28 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] power: supply: hwmon: constify pointers to
 hwmon_channel_info

On 4/7/23 15:12, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Apr 07, 2023 at 05:03:26PM +0200, Krzysztof Kozlowski wrote:
>> Statically allocated array of pointed to hwmon_channel_info can be
>> made const for safety.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>> This depends on hwmon core patch:
>> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/
>>
>> Therefore I propose this should also go via hwmon tree.
>>

I am not going to apply patches for 10+ subsystems through the hwmon tree.
This can only result in chaos. The dependent patch is available at

git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const

or wait until after the next commit window to apply this patch.

Thanks,
Guenter

>> Cc: Jean Delvare <jdelvare@...e.com>
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: linux-hwmon@...r.kernel.org
>> ---
> 
> Acked-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> 
> -- Sebastian
> 
>>   drivers/power/supply/power_supply_hwmon.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/supply/power_supply_hwmon.c b/drivers/power/supply/power_supply_hwmon.c
>> index a48aa4afb828..c97893d4c25e 100644
>> --- a/drivers/power/supply/power_supply_hwmon.c
>> +++ b/drivers/power/supply/power_supply_hwmon.c
>> @@ -293,7 +293,7 @@ static const struct hwmon_ops power_supply_hwmon_ops = {
>>   	.read_string	= power_supply_hwmon_read_string,
>>   };
>>   
>> -static const struct hwmon_channel_info *power_supply_hwmon_info[] = {
>> +static const struct hwmon_channel_info * const power_supply_hwmon_info[] = {
>>   	HWMON_CHANNEL_INFO(temp,
>>   			   HWMON_T_LABEL     |
>>   			   HWMON_T_INPUT     |
>> -- 
>> 2.34.1
>>