lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <68d22a80-663c-104a-c51c-496fa1a29d00@kernel.org>
Date:   Fri, 7 Apr 2023 08:43:30 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Saalim Quadri <danascape@...il.com>, lgirdwood@...il.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        daniel.baluta@....com, patches@...nsource.cirrus.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

On 06/04/2023 22:26, Mark Brown wrote:
> On Thu, Apr 06, 2023 at 07:38:19PM +0200, Krzysztof Kozlowski wrote:
> 
>> Please squash all your three WM bindings (wm8711, wm8580 and wm8523)
>> into one binding, if they are the same. Probably other WM from your
>> previous submissions as well. We really do not need binding per each of
>> this simple codecs. If they ever need to grow, then we can split them.
> 
> At a minimum all of these devices should have separate regulator
> specifications should they ever grow regulator support (and ideally
> would have regulators specified in the binding from the get go).

Good point. The bindings are incomplete that's why they look so similar.
Therefore maybe we should not merge them, just like we do not add
non-trivial-devices to trivial-devices schema, just because device is
incomplete.

> There's also no reason to restrict simple CODECs to a particular
> manufacturer...

True, we could extend it to other brands.

Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ