linux-kernel - Re: [PATCH v4 00/12] KVM: x86: Add AMD Guest PerfMonV2 PMU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Apr 2023 15:28:14 +0800
From:   Like Xu <like.xu.linux@...il.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 00/12] KVM: x86: Add AMD Guest PerfMonV2 PMU support

On 7/4/2023 10:02 am, Sean Christopherson wrote:
> On Tue, 14 Feb 2023 13:07:45 +0800, Like Xu wrote:
>> Starting with Zen4, core PMU on AMD platforms such as Genoa and
>> Ryzen-7000 will support PerfMonV2, and it is also compatible with
>> legacy PERFCTR_CORE behavior and msr addresses.
>>
>> If you don't have access to the hardware specification, the commits
>> d6d0c7f681fd..7685665c390d for host perf can also bring a quick
>> overview. Its main change is the addition of three msr's equivalent
>> to Intel V2, namely global_ctrl, global_status, global_status_clear.
>>
>> [...]
> 
> Applied 1-3 to kvm-x86 pmu.  Note, I grabbed my full version of patch 2 that
> also converts the "get" path.
> 
> My apologies for not reviewing this earlier in the cycle.  I need to pivot to
> TDX+SNP stuff "soon", so AMD v2 support will likely miss 6.4, but I'll prioritize
> reviewing and merging support in 6.5.

Thanks for your review time.

Since the biggest points of discussion so far is around
	[PATCH v4 11/12] KVM: x86/svm/pmu: Add AMD PerfMonV2 support,
so once the proposal on that part is confirmed by you, V5 is already in sight.

> 
> Thanks!
> 
> [01/12] KVM: x86/pmu: Rename pmc_is_enabled() to pmc_is_globally_enabled()
>          https://github.com/kvm-x86/linux/commit/cdd2fbf6360e
> [02/12] KVM: VMX: Refactor intel_pmu_{g,}set_msr() to align with other helpers
>          https://github.com/kvm-x86/linux/commit/8bca8c5ce40b
> [03/12] KVM: x86/pmu: Rewrite reprogram_counters() to improve performance
>          https://github.com/kvm-x86/linux/commit/649bccd7fac9
> 
> --
> https://github.com/kvm-x86/linux/tree/next
> https://github.com/kvm-x86/linux/tree/fixes