linux-kernel - Re: [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f79700441eddb291d97ee84d89e56e3537c3e0f0.camel@mediatek.com>
Date:   Fri, 7 Apr 2023 08:03:46 +0000
From:   Chunfeng Yun (云春峰) 
        <Chunfeng.Yun@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>
CC:     "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Eddie Hung (洪正鑫) 
        <Eddie.Hung@...iatek.com>,
        Tianping Fang (方天平) 
        <Tianping.Fang@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks

On Tue, 2023-04-04 at 08:43 -0500, Rob Herring wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Mon, Apr 03, 2023 at 10:52:29AM +0800, Chunfeng Yun wrote:
> > Add optional clock 'xhci_ck' and 'frmcnt_ck';
> > Add optional property "assigned-clock" and "assigned-clock-
> > parents";
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> > ---
> >  .../devicetree/bindings/usb/mediatek,mtu3.yaml       | 12
> > ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > index d2655173e108..50c15f2ce14d 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > @@ -66,6 +66,8 @@ properties:
> >        - description: Reference clock used by low power mode etc
> >        - description: Mcu bus clock for register access
> >        - description: DMA bus clock for data transfer
> > +      - description: DRD controller clock
> > +      - description: Frame count clock
> > 
> >    clock-names:
> >      minItems: 1
> > @@ -74,6 +76,16 @@ properties:
> >        - const: ref_ck
> >        - const: mcu_ck
> >        - const: dma_ck
> > +      - const: xhci_ck
> > +      - const: frmcnt_ck
> > +
> > +  assigned-clocks:
> > +    minItems: 1
> > +    maxItems: 6
> > +
> > +  assigned-clock-parents:
> > +    minItems: 1
> > +    maxItems: 6
> 
> You don't need to include assigned-clocks properties. They are
> implicitly allowed (when clocks is present).
Got it, will modify it, thanks a lot

> 
> Rob