linux-kernel - Re: [PATCH] fuse: remove unnecessary goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230407082627.oh2l4lfltmxy52nx@green5>
Date:   Fri, 7 Apr 2023 13:56:27 +0530
From:   Nitesh Shetty <nj.shetty@...sung.com>
To:     Yangtao Li <frank.li@...o.com>
Cc:     Miklos Szeredi <miklos@...redi.hu>, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fuse: remove unnecessary goto

On 23/04/07 03:56AM, Yangtao Li wrote:
>In this case, the error code can be returned directly.
>
>Signed-off-by: Yangtao Li <frank.li@...o.com>
>---
> fs/fuse/inode.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
>index d66070af145d..56efcf160513 100644
>--- a/fs/fuse/inode.c
>+++ b/fs/fuse/inode.c
>@@ -1921,10 +1921,8 @@ static int fuse_sysfs_init(void)
> 	int err;
>
> 	fuse_kobj = kobject_create_and_add("fuse", fs_kobj);
>-	if (!fuse_kobj) {
>-		err = -ENOMEM;
>-		goto out_err;
>-	}
>+	if (!fuse_kobj)
>+		return -ENOMEM;
>
> 	err = sysfs_create_mount_point(fuse_kobj, "connections");
> 	if (err)
>@@ -1934,7 +1932,6 @@ static int fuse_sysfs_init(void)
>
>  out_fuse_unregister:
> 	kobject_put(fuse_kobj);
>- out_err:
> 	return err;
> }
>
>-- 
>2.35.1
>
Reviewed by: Nitesh Shetty <nj.shetty@...sung.com>