linux-kernel - Re: [PATCH net-next v2] qlcnic: check pci_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZC/b2lP5+MRwcGqb@corigine.com>
Date:   Fri, 7 Apr 2023 11:01:14 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Denis Plotnikov <den-plotnikov@...dex-team.ru>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        anirban.chakraborty@...gic.com, sony.chacko@...gic.com,
        GR-Linux-NIC-Dev@...vell.com, helgaas@...nel.org,
        manishc@...vell.com, shshaikh@...vell.com
Subject: Re: [PATCH net-next v2] qlcnic: check pci_reset_function result

On Fri, Apr 07, 2023 at 10:18:49AM +0300, Denis Plotnikov wrote:
> Static code analyzer complains to unchecked return value.
> The result of pci_reset_function() is unchecked.
> Despite, the issue is on the FLR supported code path and in that
> case reset can be done with pcie_flr(), the patch uses less invasive
> approach by adding the result check of pci_reset_function().
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 7e2cf4feba05 ("qlcnic: change driver hardware interface mechanism")
> Signed-off-by: Denis Plotnikov <den-plotnikov@...dex-team.ru>

Thanks Denis,

With reference to,

Link: https://lore.kernel.org/all/20230405193708.GA3632282@bhelgaas/

I think this is the best approach in lieu of feedback from those
with knowledge of the hardware / testing on the hardware.

Reviewed-by: Simon Horman <simon.horman@...igine.com>

> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> index 87f76bac2e463..eb827b86ecae8 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
> @@ -628,7 +628,13 @@ int qlcnic_fw_create_ctx(struct qlcnic_adapter *dev)
>  	int i, err, ring;
>  
>  	if (dev->flags & QLCNIC_NEED_FLR) {
> -		pci_reset_function(dev->pdev);
> +		err = pci_reset_function(dev->pdev);
> +		if (err) {
> +			dev_err(&dev->pdev->dev,
> +				"Adapter reset failed (%d). Please reboot\n",
> +				err);
> +			return err;
> +		}
>  		dev->flags &= ~QLCNIC_NEED_FLR;
>  	}
>  
> -- 
> 2.25.1
>