linux-kernel - Re: [PATCH v3 1/2] test_firmware: Fix some racing conditions in test_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Apr 2023 12:03:35 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Russ Weight <russell.h.weight@...el.com>,
        linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>,
        Tianfei zhang <tianfei.zhang@...el.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Zhengchao Shao <shaozhengchao@...wei.com>,
        Colin Ian King <colin.i.king@...il.com>,
        Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH v3 1/2] test_firmware: Fix some racing conditions in
 test_fw_config locking.

On Fri, Apr 07, 2023 at 10:24:24AM +0200, Mirsad Goran Todorovac wrote:
> 
> Hi Mr. Carpenter,
> 
> Thank you for your review.
> 
> I will proceed according to your guidelines and issue the next version of the
> patch set.
> 
> But I cannot promise it will be before the holidays - I do not want to make
> the gods angry either ;-)
> 

There is never a rush.

> I cannot promise to try smart macros or inline functions with smart function
> parameters just yet.
> 

Don't worry about that.  It just seemed like you were working towards
a more general purpose infrastructure.  It's just a clean up.

> I would consider the real success if I hunt down the remaining leak and races
> in this driver. Despite being considered a less important one.
> 
> As you have previously asserted, it is not a real security issue with a CVE,
> however, for completeness sake I would like to see these problems fixed.

That's great.  If you get bored and feel like giving up then just send
PATCH 2/2 by itself because that one could be merged as is.

regards,
dan carpenter