linux-kernel - Re: [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d792cf15-4263-44f2-ba93-a2479662fbe9@roeck-us.net>
Date:   Fri, 7 Apr 2023 09:00:23 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        peter.ganzhorn@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message

On Thu, Mar 30, 2023 at 06:33:45PM +0800, Zhang Rui wrote:
> After commit c0c67f8761ce ("hwmon: (coretemp) Add support for dynamic
> tjmax"), tjmax value is retrieved from MSR every time the temperature is
> read.
> This means that, with debug message enabled, the tjmax debug message is
> printed out for every single temperature read for any CPU. This spams
> the syslog.
> 
> Ideally, as tjmax is package scope unique, the debug message should show
> once when tjmax is changed for one package. But this requires inventing
> some new per-package data in the coretemp driver, and this is overkill.
> 
> To keep the code simple, delete the tjmax debug message.
> 
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/coretemp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 30d77f451937..fe3d4d0dcbed 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -286,10 +286,8 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
>  		 * If the TjMax is not plausible, an assumption
>  		 * will be used
>  		 */
> -		if (val) {
> -			dev_dbg(dev, "TjMax is %d degrees C\n", val);
> +		if (val)
>  			return val * 1000;
> -		}
>  	}
>  
>  	if (force_tjmax) {