linux-kernel - Re: [PATCH] fpga: dfl-fme: constify pointers to hwmon_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Apr 2023 09:24:53 -0700
From:   Russ Weight <russell.h.weight@...el.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
        Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>,
        <linux-fpga@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH] fpga: dfl-fme: constify pointers to hwmon_channel_info

 
On 4/7/23 08:01, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.

Reviewed-by: Russ Weight <russell.h.weight@...el.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> ---
>
> This depends on hwmon core patch:
> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/
>
> Therefore I propose this should also go via hwmon tree.
>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: linux-hwmon@...r.kernel.org
> ---
>  drivers/fpga/dfl-fme-main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
> index 77ea04d4edbe..bcb5d34b3b82 100644
> --- a/drivers/fpga/dfl-fme-main.c
> +++ b/drivers/fpga/dfl-fme-main.c
> @@ -265,7 +265,7 @@ static const struct hwmon_ops thermal_hwmon_ops = {
>  	.read = thermal_hwmon_read,
>  };
>  
> -static const struct hwmon_channel_info *thermal_hwmon_info[] = {
> +static const struct hwmon_channel_info * const thermal_hwmon_info[] = {
>  	HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_EMERGENCY |
>  				 HWMON_T_MAX   | HWMON_T_MAX_ALARM |
>  				 HWMON_T_CRIT  | HWMON_T_CRIT_ALARM),
> @@ -465,7 +465,7 @@ static const struct hwmon_ops power_hwmon_ops = {
>  	.write = power_hwmon_write,
>  };
>  
> -static const struct hwmon_channel_info *power_hwmon_info[] = {
> +static const struct hwmon_channel_info * const power_hwmon_info[] = {
>  	HWMON_CHANNEL_INFO(power, HWMON_P_INPUT |
>  				  HWMON_P_MAX   | HWMON_P_MAX_ALARM |
>  				  HWMON_P_CRIT  | HWMON_P_CRIT_ALARM),