linux-kernel - Re: [PATCH] media: i2c: video: constify pointers to hwmon_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2294f1fa-019e-4278-804a-3a9ea807b23f@roeck-us.net>
Date:   Fri, 7 Apr 2023 11:08:32 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sakari Ailus <sakari.ailus@....fi>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] media: i2c: video: constify pointers to
 hwmon_channel_info

On Fri, Apr 07, 2023 at 08:16:30PM +0300, Sakari Ailus wrote:
> Hi Krzysztof,
> 
> On Fri, Apr 07, 2023 at 05:00:15PM +0200, Krzysztof Kozlowski wrote:
> > Statically allocated array of pointed to hwmon_channel_info can be made
> > const for safety.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > 
> > ---
> > 
> > This depends on hwmon core patch:
> > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/
> > 
> > Therefore I propose this should also go via hwmon tree.
> 
> Works for me. Please add:
> 

But not for me. Krzysztof jumped the gun here a bit.
I do not feel comfortable applying patches for 10+ subsystem
branches through hwmon. This is asking for trouble.

I created a stable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const

which everyone may use to merge the pre-requisite patch, or wait until
after the next merge window. 

Guenter