linux-kernel - Re: [PATCH] bus: fsl-mc: remove unused free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdmBu_foPCtXBNoA+ZDd-kU4X5-c65NVJb-MSrgoMKNJxw@mail.gmail.com>
Date:   Fri, 7 Apr 2023 11:13:55 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Tom Rix <trix@...hat.com>
Cc:     stuyoder@...il.com, laurentiu.tudor@....com, nathan@...nel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] bus: fsl-mc: remove unused free_count variable

On Thu, Mar 30, 2023 at 5:12 PM Tom Rix <trix@...hat.com> wrote:
>
> clang with W=1 reports
> drivers/bus/fsl-mc/fsl-mc-allocator.c:560:6: error: variable
>   'free_count' set but not used [-Werror,-Wunused-but-set-variable]
>         int free_count = 0;
>             ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Thanks for the patch!

Fixes: commit d8e026a44919 ("staging: fsl-mc: remove some superfluous WARN_ONs")
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

Check out
commit 364069556901 ("staging: fsl-mc: move resource pool init/cleanup
into allocator")
to see the original logic.

> ---
>  drivers/bus/fsl-mc/fsl-mc-allocator.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl-mc-allocator.c
> index dced427ca8ba..f1351237a9d5 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
> @@ -557,12 +557,9 @@ static void fsl_mc_cleanup_resource_pool(struct fsl_mc_device *mc_bus_dev,
>         struct fsl_mc_bus *mc_bus = to_fsl_mc_bus(mc_bus_dev);
>         struct fsl_mc_resource_pool *res_pool =
>                                         &mc_bus->resource_pools[pool_type];
> -       int free_count = 0;
>
> -       list_for_each_entry_safe(resource, next, &res_pool->free_list, node) {
> -               free_count++;
> +       list_for_each_entry_safe(resource, next, &res_pool->free_list, node)
>                 devm_kfree(&mc_bus_dev->dev, resource);
> -       }
>  }
>
>  void fsl_mc_cleanup_all_resource_pools(struct fsl_mc_device *mc_bus_dev)
> --
> 2.27.0
>


-- 
Thanks,
~Nick Desaulniers