linux-kernel - Re: [PATCH net] net: phy: nxp-c45-tja11xx: add remove callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9bd7373-f544-45fc-be3b-736d20f0841a@lunn.ch>
Date:   Fri, 7 Apr 2023 20:15:00 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: add remove callback

> > Do you need to disable interrupts? I suppose the real question is, is
> > it guaranteed phy_disconnect() is called before the driver is removed?
> The MAC driver should call phy_disconnect() when it is removed. Also, the
> user should not be able to remove the PHY driver if is in uses.

That was what i was thinking. But i've never unloaded a PHY driver, so
i've no idea what actually happens.

     Andrew