linux-kernel - Re: [PATCH] [media] mb86a20s: remove unused active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdkzW41CXskgY8h6V321kQyDv8DjvYC02YdK71QKEB2g=Q@mail.gmail.com>
Date:   Fri, 7 Apr 2023 11:27:52 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Tom Rix <trix@...hat.com>
Cc:     mchehab@...nel.org, nathan@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] [media] mb86a20s: remove unused active_layers variable

On Fri, Mar 31, 2023 at 6:05 PM Tom Rix <trix@...hat.com> wrote:
>
> clang with W=1 reports
> drivers/media/dvb-frontends/mb86a20s.c:1572:6: error: variable
>   'active_layers' set but not used [-Werror,-Wunused-but-set-variable]
>         int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
>             ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Thanks for the patch!
Fixes: 149d518ad0fd ("[media] mb86a20s: add BER measurement")
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

> ---
>  drivers/media/dvb-frontends/mb86a20s.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/mb86a20s.c b/drivers/media/dvb-frontends/mb86a20s.c
> index b74b9afed9a2..125fed4891ba 100644
> --- a/drivers/media/dvb-frontends/mb86a20s.c
> +++ b/drivers/media/dvb-frontends/mb86a20s.c
> @@ -1569,7 +1569,7 @@ static int mb86a20s_get_stats(struct dvb_frontend *fe, int status_nr)
>         u32 t_post_bit_error = 0, t_post_bit_count = 0;
>         u32 block_error = 0, block_count = 0;
>         u32 t_block_error = 0, t_block_count = 0;
> -       int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
> +       int pre_ber_layers = 0, post_ber_layers = 0;
>         int per_layers = 0;
>
>         dev_dbg(&state->i2c->dev, "%s called.\n", __func__);
> @@ -1589,9 +1589,6 @@ static int mb86a20s_get_stats(struct dvb_frontend *fe, int status_nr)
>
>         for (layer = 0; layer < NUM_LAYERS; layer++) {
>                 if (c->isdbt_layer_enabled & (1 << layer)) {
> -                       /* Layer is active and has rc segments */
> -                       active_layers++;
> -
>                         /* Handle BER before vterbi */
>                         rc = mb86a20s_get_pre_ber(fe, layer,
>                                                   &bit_error, &bit_count);
> --
> 2.27.0
>


-- 
Thanks,
~Nick Desaulniers