linux-kernel - Re: [PATCH] ufs: hwmon: constify pointers to hwmon_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb4f40e7-fd06-1e94-02ab-b26d1418e782@linaro.org>
Date:   Fri, 7 Apr 2023 20:49:53 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bart Van Assche <bvanassche@....org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] ufs: hwmon: constify pointers to hwmon_channel_info

On 07/04/2023 20:30, Bart Van Assche wrote:
> On 4/7/23 08:01, Krzysztof Kozlowski wrote:
>> -static const struct hwmon_channel_info *ufs_hwmon_info[] = {
>> +static const struct hwmon_channel_info * const ufs_hwmon_info[] = {
>>   	HWMON_CHANNEL_INFO(temp, HWMON_T_ENABLE | HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LCRIT),
>>   	NULL
>>   };
> 
> A nit: to me the use of whitespace in this patch does not seem to be 
> compliant with the Linux kernel coding style.

You mean it should be:
	hwmon_channel_info *const ufs_hwmon_info
?

I think the pointer * is tied only to variable name, but not to const.
Majority seems to choose similarly:

git grep "\*const" | wc -l
2763
git grep "\* const" | wc -l
16204

But if this is more than a nit, but your preference, I can fix it.

Best regards,
Krzysztof